Migrate from dart_skills_lint to skills_lint - #9974
Conversation
|
cc @reidbaker for review |
- Update tool/pubspec.yaml dependency from dart_skills_lint to skills_lint - Rename tool/dart_skills_lint.yaml to tool/skills_lint.yaml and update root key - Rename .agents/skills/dart_skills_lint_ignore.json to skills_lint_ignore.json - Update validate_skills_test.dart imports and config file path - Update validate_skills_hook.sh to use flutter pub run skills_lint
141fba9 to
a574df7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the project's skill validation tool from dart_skills_lint to skills_lint. This involves updating the validation hook script, the configuration file, dependencies in pubspec.lock and tool/pubspec.yaml, and the corresponding test file. The review feedback suggests using the modern dart run command instead of the deprecated dart pub run in the validation hook script.
pq
left a comment
pq
left a comment
There was a problem hiding this comment.
Modulo the preferring dart run comment, LGTM!
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
reidbaker
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/devtools/9974, because - The status or check suite ubuntu-latest test_ddc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
squashing instead of autosubmit because of a flakey test. see github.com/flutter/devtools/issues/9484 |
4 participants
The skills_lint code is moving out of flutter/agent-plugins to its own github repo skills_lint.dart.
Related to #9974
Agent authored description
Follows the migration guide in
google/skills_lint.dartto migrate DevTools fromdart_skills_linttoskills_lint.Changes
tool/pubspec.yamldependency to useskills_lintfromhttps://github.com/google/skills_lint.dart.git.tool/dart_skills_lint.yamltotool/skills_lint.yamland update top-level YAML key toskills_lint:..agents/skills/dart_skills_lint_ignore.jsonto.agents/skills/skills_lint_ignore.json.tool/test/validate_skills_test.dartimports and config path..agents/scripts/validate_skills_hook.shto usedart pub run skills_lint.Pre-launch Checklist
///).